Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtd: set the OS and Python versions explicitly #357

Merged
merged 1 commit into from
May 10, 2023
Merged

rtd: set the OS and Python versions explicitly #357

merged 1 commit into from
May 10, 2023

Conversation

daniloegea
Copy link
Collaborator

@daniloegea daniloegea commented May 10, 2023 •
edited by slyon
Loading

The RTD build is failing due to a new version of urllib3. According to [1], this change should fix the problem.

[1] - readthedocs/readthedocs.org#10290

Description

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@daniloegea
rtd: set the OS and Python versions explicitly
ee50517 
The RTD build is failing due to a new version of urllib3. According to
[1], this change should fix the problem.

[1] - readthedocs/readthedocs.org#10290
slyon
slyon approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems to do the trick. +1

@slyon slyon merged commit 29b7a24 into canonical:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slyon slyon slyon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniloegea @slyon