Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests:integration: Adopt for systemd v254 (Closes: #1041310) #381

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

slyon
Copy link
Collaborator

@slyon slyon commented Jul 18, 2023

Description

systemd-networkd v245 seems to be more picky about moving an interface from "configuring" to "configured" state. It waits for an IPv6 RA to be received. So we need to define "accept-ra: false" in Netplan tests to ignore that, or make our test environment (dnsmasq) to actually provide RAs. I went with the latter.

We still see weird error messages from 'networkctl', which seems new, but they do not fail tests. E.g.: Failed to query link bit rates: Invalid argument
Failed to query link DHCP leases: Invalid argument

I have the impression that those error messages are thrown while the interface is still in "configuring" state, i.e. while waiting for the RA to be received/processed. We're calling 'networkctl status IFACE' in a loop and the error message vanishes when calling the command after a few seconds.

https://bugs.debian.org/1041310

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

systemd-networkd v245 seems to be more picky about moving an interface from "configuring" to "configured" state.
It waits for an IPv6 RA to be received. So we need to define "accept-ra: false" in Netplan tests to ignore that,
or make our test environment (dnsmasq) to actually provide RAs. I went with the latter.

We still see weird error messages from 'networkctl', which seems new, but they do not fail tests. E.g.:
Failed to query link bit rates: Invalid argument
Failed to query link DHCP leases: Invalid argument

I have the impression that those error messages are thrown while the interface is still in "configuring" state,
i.e. while waiting for the RA to be received/processed. We're calling 'networkctl status IFACE' in a loop and
the error message vanishes when calling the command after a few seconds.
@slyon slyon requested a review from daniloegea July 18, 2023 15:29
@slyon
Copy link
Collaborator Author

slyon commented Jul 18, 2023

cc @bluca

@slyon slyon changed the title tests:integration: Adopt for systemd v254 tests:integration: Adopt for systemd v254 (Closes: #1041310) Jul 18, 2023
@bluca
Copy link

bluca commented Jul 18, 2023

We still see weird error messages from 'networkctl', which seems new, but they do not fail tests. E.g.: Failed to query link bit rates: Invalid argument
Failed to query link DHCP leases: Invalid argument

Those are due to a bug that is going to be fixed by: systemd/systemd#28447

Copy link
Collaborator

@daniloegea daniloegea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@slyon slyon merged commit 5851195 into canonical:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants