Post 0.107 cleanup & dropping API/ABI compat #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Few more things to remember:
|
see #401 |
slyon
force-pushed
the
post-0107
branch
8 times, most recently
from
3796fb9
to
e6e8d20
Compare
slyon
force-pushed
the
post-0107
branch
2 times, most recently
from
5c3fda5
to
706ccf9
Compare
slyon
changed the title
slyon
force-pushed
the
post-0107
branch
4 times, most recently
from
b11fec3
to
dd71696
Compare
daniloegea
requested changes
Jan 15, 2024
slyon
force-pushed
the
post-0107
branch
8 times, most recently
from
7dd4f86
to
c152ea4
Compare
New ctests to satisfy coverage
|
Thanks for your review @daniloegea ! I've addressed all of your comments and got the CI to be green (except for the known tunnel/GRE failures on Jammy autopkgtest, which are unrelated). PTAL. |
daniloegea
approved these changes
Jan 16, 2024
| @@ -45,7 +45,12 @@ jobs: | |||
| pull-lp-source netplan.io | |||
| cp -r netplan.io-*/debian . | |||
| rm -r debian/patches/ # clear any distro patches | |||
| sed -i 's|rm debian/tmp/lib/netplan/generate|# DELETED|' debian/rules | |||
| # usrmerge-fix | |||
| mkdir debian/extra | |||
There was a problem hiding this comment.
I believe this will start to fail when your changes get synced with Ubuntu but we can fix the CI again later.
There was a problem hiding this comment.
Yes. And I just uploaded 0.107.1-2 into Debian unstable. I'll use my next PR to adopt CI accordingly, once that landed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
Please review commit-by-commit (and ignore the huge "ABI: regenerate compat check for dropped symbols" commit in
abi-compat/*.xml-- it's autogenerated)Unrelated changes
This PR contains some unrelated "cleanup" changes for post 0.107 tasks.
Primary changes
The primary changes, of dropping legacy Netplan API and ABI (in preparation for a breaking 1.0 release) start from commit "test:generator:base: Refactor to use new API".
Checklist
make checksuccessfully.make check-coverage).