Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mii-monitor-interval #411

Merged
merged 2 commits into from
Sep 27, 2023
Merged

added mii-monitor-interval #411

merged 2 commits into from
Sep 27, 2023

Conversation

Sudo-Whodo
Copy link
Contributor

…needed

Description

I added mii-monitor-interval to the example so the active-backup connection would failover. The default value is 0 and doesn't monitor the carrier connection.

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@daniloegea daniloegea added the community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. label Sep 27, 2023
@daniloegea
Copy link
Collaborator

Hi there, thank you for your PR.

The default time unit, when not specified, is milliseconds. I wonder if 1 millisecond is a too small value... Was it your intention setting it to 1 second instead? If so, it must be defined as 1s.

updated to 100ms
@Sudo-Whodo
Copy link
Contributor Author

Sudo-Whodo commented Sep 27, 2023

Hey, My main goal with the pr is to enable the mii monitoring for the active-backup example. I used this as a template and went to test the failover and it didn't happen. Once I added the mii-monitor-interval it failed-over as intended. I've updated the value to 100ms. This is from the Mikrotik default value I saw online in their [docs](MII monitoring), but the desire is to add a positive int value.

@daniloegea
Copy link
Collaborator

Yes, I got it :)
But the thing with example files is that people will copy and paste them as they are and some settings might cause problems. I'm not really sure if the 1ms mii monitor would cause any issues but I feel like polling something every millisecond might cause unnecessary load.

Anyway, thanks for your patch ;)

@daniloegea daniloegea merged commit 398a948 into canonical:main Sep 27, 2023
13 checks passed
@slyon slyon added the documentation Documentation improvements. label Oct 12, 2023
daniloegea pushed a commit that referenced this pull request Dec 12, 2023
* added mii-monitor-interval to monitor the connection and failover if needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants