-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial improvements #458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, Robert!
I very much like the breaking down of the big tutorial into smaller chunks and the overall structural improvements.
I wonder if the new how-to guides should be linked from the bottom of the tutorial, e.g. in a "Future reading" section or so?
I've left a few inline comments of broken links and one logical question wrt IPv6 addresses which shouldn't be there.. Those should be fixed before merging.
@daniloegea Do you have anything to add to this, as it was your document intially?
50672ac
to
9201312
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Robert. I looks good. I just found a typo you might want to fix.
9201312
to
5ecdd02
Compare
5ecdd02
to
3ee377f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the remarks! LGTM
note: I pushed a tiny fix for whitespace formatting in the CLI output.
Description
This PR revamps the Netplan tutorial:
In addition:
Fixes FR-2811.