Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse: fix redefinition of gateway(4|6) #460

Merged
merged 1 commit into from
Apr 19, 2024

Commits on Apr 18, 2024

  1. parse: fix redefinition of gateway(4|6)

    Options gateway4 and gateway6 were not being properly redefined when a
    merge happens. Redefinition was causing a crash due to an assert in the
    set_str_if_null macro.
    
    While this assertion helped identifying the merge issue, I believe it's
    not the best place to keep it so I'm removing it from the macro and
    making the macro do only what it name suggests it does.
    
    This macro is used in other places but this problem seems to not happen
    there as far as I can see.
    
    Add a couple of unit test to check the merge is working.
    daniloegea committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    427599a View commit details
    Browse the repository at this point in the history