Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emitter: allow unicode characters in the emitter (LP: #2071652) #485

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

daniloegea
Copy link
Collaborator

@daniloegea daniloegea commented Jul 2, 2024

The YAML emitter from libyaml will convert non-ascii characters to latin1 by default.

See LP: #2071652

Description

See https://bugs.launchpad.net/netplan/+bug/2071652 for details.

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@daniloegea daniloegea force-pushed the set_unicode branch 2 times, most recently from 28ccbbe to 7d6844a Compare July 2, 2024 14:30
@daniloegea daniloegea marked this pull request as ready for review July 2, 2024 16:41
@daniloegea daniloegea requested a review from slyon July 2, 2024 16:41
@slyon slyon changed the title emitter: allow unicode characters in the emitter emitter: allow unicode characters in the emitter (LP: #2071652) Jul 3, 2024
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👀

This is ready for merging, after the small "password" vs "psk" confusion is fixed.
(Well, I guess the test for the yaml emitter also works via passthrough, but we'd still want it to use the proper structure and fields.)

tests/ctests/test_netplan_keyfile.c Outdated Show resolved Hide resolved
tests/ctests/test_netplan_keyfile.c Outdated Show resolved Hide resolved
The YAML emitter from libyaml will convert non-ascii characters to
latin1 by default.

See LP: #2071652
@slyon slyon merged commit 2945ea3 into canonical:main Jul 3, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants