Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add netplan try to netplan tutorial #494

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Add netplan try to netplan tutorial #494

merged 2 commits into from
Aug 12, 2024

Conversation

davidekete
Copy link
Contributor

Description

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@davidekete davidekete mentioned this pull request Aug 1, 2024
Closed
rkratky
rkratky approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slyon Could you please have a look at this (and merge if OK from your side)?

@rkratky rkratky requested a review from slyon August 2, 2024 12:56
@slyon slyon added community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements. labels Aug 12, 2024
slyon
slyon approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution to the Netplan project @davidekete!

LGTM, I will merge it shortly. Sorry for the late reply (I was travelling).

@slyon slyon merged commit a955b0d into canonical:main Aug 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slyon slyon slyon approved these changes

@rkratky rkratky rkratky approved these changes

Assignees
No one assigned
Labels
community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidekete @slyon @rkratky