Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Grafana dashboard shows data #344

Merged
merged 5 commits into from
Apr 5, 2024
Merged

fix: Grafana dashboard shows data #344

merged 5 commits into from
Apr 5, 2024

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Mar 27, 2024

  • Fix jupyter-controller's grafana dashboard by removing uid from the datasource fields.
  • Add tag ckf to dashboard.

Part of canonical/bundle-kubeflow#856
Refs canonical/bundle-kubeflow#834

Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in a ckf deployment and both dashboards lgtm!
image

just a nit comment before we merge

NohaIhab
NohaIhab previously approved these changes Apr 5, 2024
@orfeas-k orfeas-k merged commit 633950b into main Apr 5, 2024
14 checks passed
@orfeas-k orfeas-k deleted the kf-5488-fix-dashboard branch April 5, 2024 10:37
orfeas-k added a commit that referenced this pull request Apr 9, 2024
* Remove `uid` from the `datasource` fields.
* fix typo
* Add tag `ckf` to dashboard.
* Increase retry_for_attempts to 10 attempts
* unpin prometheus

Part of canonical/bundle-kubeflow#856
Refs canonical/bundle-kubeflow#834
orfeas-k added a commit that referenced this pull request Apr 9, 2024
* Remove `uid` from the `datasource` fields.
* fix typo
* Add tag `ckf` to dashboard.
* Increase retry_for_attempts to 10 attempts
* unpin prometheus

Part of canonical/bundle-kubeflow#856
Ref canonical/bundle-kubeflow#834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants