fix rock for ckf-1.7 #15
Conversation
previously, the rock's workload would not start, instead crashing on: > level=fatal msg="open web/templates/default: no such file or directory" because the web files were not copied to the working directory. This commit refactors the rock and the working directory to be identical to the upstream docker image
ca-scribner
force-pushed
the
KF-5091-fix-rock-for-1.7
branch
from
d892921
to
9517371
Compare
|
Haven't reviewed the PR but would it make sense updating those too in this PR to be CKF 1.7 compatible? |
|
@orfeas-k re microk8s and juju versions, that's a good question... that workflow doesn't capture how different tracks need different settings - I'm not sure how to capture that either way, there is no actual integration test in this repo :D So that part of the testing wont matter atm anyway. Can we tackle this in #13? |
That should be job of the repo's branches I guess and at least in one rock repos, that's more than fine. We can def tackle this as part of #13. |
There was a problem hiding this comment.
Tested the rock in a CKF 1.7 deployment and works. I created a notebook and connected to it as well. @kimwnasptd had some comments in a live discussion but they can be tackled in a future PR since this ROCK is functional. Thank you @ca-scribner
previously, the rock's workload would not start, instead crashing on:
because the web files were not copied to the working directory. This commit refactors the rock and the working directory to be identical to the upstream docker image
Reviewer notes