Openfga relation interface update 01 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesstimec
force-pushed
the
openfga-relation-interface-update-01
branch
from
ae66259
to
ca41991
Compare
babakks
approved these changes
Jun 23, 2023
kian99
approved these changes
Jun 23, 2023
| self.state = PeerRelationState(self.model, self.app, "openfga-peer") | ||
| port_http = ServicePort(8080, name=f"{self.app.name}-http", protocol="TCP") | ||
| port_grpc = ServicePort(8081, name=f"{self.app.name}-grpc", protocol="TCP") | ||
| self.service_patcher = KubernetesServicePatch(self, [port_http, port_grpc]) |
There was a problem hiding this comment.
I think Ali might have a way of handling multiple ingress ports without the K8ServicePatch now. Something for the future.
| return | ||
|
|
||
| if not self._state.token_secret_id: | ||
| token = secrets.token_urlsafe(32) |
There was a problem hiding this comment.
What is this 32 bit? Should we make it a constant so it has a name?
There was a problem hiding this comment.
i don't know.. it think this is ok
|
|
||
| self._create_token_secret(event) | ||
|
|
||
| # Quickly update logrotates config each workload update |
There was a problem hiding this comment.
It's python so arguably it won't be running quickly.
alesstimec
force-pushed
the
openfga-relation-interface-update-01
branch
4 times, most recently
from
984dca5
to
4342f9c
Compare
babakks
approved these changes
Jun 26, 2023
kian99
approved these changes
Jun 26, 2023
| logger.info("created token secret {}".format(secret.id)) | ||
|
|
||
| @must_be_leader | ||
| @requires_state |
There was a problem hiding this comment.
Really like the decorators, very nice.
|
Oh and gentle reminder about committing without |
- uses secrets to transfer tokens via relations - updated to use the new state implementation
alesstimec
force-pushed
the
openfga-relation-interface-update-01
branch
from
4342f9c
to
e42aed7
Compare
alesstimec
added a commit
to alesstimec/public-cs-openfga
that referenced
this pull request
Jul 5, 2023
…rface-update-01 Openfga relation interface update 01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The what and why - include a summary of the change, describe what it does, and include relevant motivation and context.
Fixes JIRA/GitHub issue number
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers