Refactor charm code base #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsklikas
force-pushed
the
IAM-569
branch
2 times, most recently
from
06717fa
to
5e946bb
Compare
nsklikas
force-pushed
the
IAM-569
branch
2 times, most recently
from
175836b
to
6e6be38
Compare
nsklikas
force-pushed
the
IAM-569
branch
2 times, most recently
from
0b21135
to
6a143b0
Compare
nsklikas
force-pushed
the
IAM-569
branch
2 times, most recently
from
7437237
to
a17b7ff
Compare
natalian98
reviewed
Oct 31, 2023
| logger.info("workload container not ready - deferring") | ||
| event.defer() | ||
| return | ||
|
|
||
| def _on_peer_relation_changed(self, event): | ||
| self._container.restart(SERVICE_NAME) |
There was a problem hiding this comment.
I would put it in a try except block, in case it fails to restart
Suggested change
| self._container.restart(SERVICE_NAME) | |
| try: | |
| self._container.restart(SERVICE_NAME) | |
| except ChangeError as err: | |
| logger.error(str(err)) | |
| self.unit.status = BlockedStatus("Failed to restart the container, please consult the logs") | |
| return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IAM-569
Refactor charm codebase. This PR includes a lot of changes, perhaps I should break it up into smaller PRs to make reviewing easier. It include changes for:
already existserror that I couldn't replicate so I removed it).dns_namein the openfga databag included the HTTP scheme if traefik was related. I removed it, not sure if it was untested or intentional. If there any issues with this I will revert it to the way it was (cc @alesstimec)Future work:
charm-relation-interfacesspec.