Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: properly mock the environment #1385

Merged
merged 1 commit into from
Sep 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/test_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -3242,7 +3242,7 @@ def test_relation_remote_app_name_env(self, monkeypatch: pytest.MonkeyPatch):
monkeypatch.setenv('JUJU_RELATION_ID', 'x:5')
monkeypatch.setenv('JUJU_REMOTE_APP', 'remoteapp1')
assert self.backend.relation_remote_app_name(5) == 'remoteapp1'
os.environ['JUJU_RELATION_ID'] = '5'
monkeypatch.setenv('JUJU_RELATION_ID', '5')
assert self.backend.relation_remote_app_name(5) == 'remoteapp1'

def test_relation_remote_app_name_script_success(
Expand All @@ -3266,7 +3266,7 @@ def test_relation_remote_app_name_script_success(

# JUJU_RELATION_ID unset but JUJU_REMOTE_APP set
monkeypatch.delenv('JUJU_RELATION_ID')
os.environ['JUJU_REMOTE_APP'] = 'remoteapp1'
monkeypatch.setenv('JUJU_REMOTE_APP', 'remoteapp1')
assert self.backend.relation_remote_app_name(5) == 'remoteapp2'

# Both set, but JUJU_RELATION_ID a different relation
Expand Down
Loading