chore: update api-server to 2.2.0 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DnPlas
reviewed
Jun 20, 2024
DnPlas
previously approved these changes
Jun 20, 2024
There was a problem hiding this comment.
I have built and run the image. I saw this:
_daemon_@ac591692f9e4:/$ /bin/apiserver --config=/config --sampleconfig=/config/sample_config.json -logtostderr=true
I0620 19:05:20.802271 9 client_manager.go:170] Initializing client manager
I0620 19:05:20.802379 9 config.go:57] Config DBConfig.MySQLConfig.ExtraParams not specified, skipping
F0620 19:11:45.211662 9 error.go:425] dial tcp: lookup mysql on 172.31.0.2:53: no such host
I think the server tries to start and fails because it is waiting for mysql, so I think we're good. Thanks @orfeas-k ! I left a comment that is not super critical for this PR.
|
Updated since I realized I had probably compared wrong files and thought there were no changes introduced so I brought another change that was missing. |
|
I just pushed one more commit due to this error during rock build (wasn't here one day ago :P) |
DnPlas
reviewed
Jun 21, 2024
Co-authored-by: Daniela Plascencia <[email protected]>
DnPlas
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: I also did some refactoring based on #93.
Closes #82