Added ml-metadata-store rockfile
#115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NohaIhab
reviewed
Oct 21, 2024
| @@ -0,0 +1,58 @@ | |||
| # Based on: https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol/Dockerfile | |||
There was a problem hiding this comment.
should be:
Suggested change
| # Based on: https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol/Dockerfile | |
| # Based on: https://github.com/google/ml-metadata/blob/v1.14.0/ml_metadata/tools/docker_server/Dockerfile |
|
|
||
| platforms: | ||
| amd64: | ||
|
|
There was a problem hiding this comment.
missing the service details
| bazel build -c opt --action_env=PATH \ | ||
| --define=grpc_no_ares=true --verbose_failures \ | ||
| //ml_metadata/metadata_store:metadata_store_server --cxxopt="-std=c++17" | ||
|
|
There was a problem hiding this comment.
missing the step to copy libmysqlclient source onto third_party folder
There was a problem hiding this comment.
need to install tzdata package in the final rock, see in the Dockerfile
There was a problem hiding this comment.
can you add the sanity tests to check for the:
- binary in
/bin/metadata_store_server - third party files in
/mlmd-src/third_party
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description