Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update visualisation server to v2.2.0 #92

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

misohu
Copy link
Member

@misohu misohu commented Jun 7, 2024

Closes: #87

I have compared tags 2.0.5 and 2.2.0 for this file https://github.com/kubeflow/pipelines/blob/2.2.0/backend/Dockerfile.visualization and there were no changes.

Changes:

  • I have cleaned up the structure of the rockcraft.yaml to be the same as in other ROCKs.
  • I have changed the base os to 22.04 (because of this there are some changes as 3.8 is not default python)
  • I have added security team requirement
  • I have added sanity tests

Note: when you build the ROCK and and run it locally with docker the server does not have any output. The only way to test if the rock is really working is to ssh to running rock and inspect the processes (you can also just ssh to running ROCK and try to rrun it again from inside, if the rock is working the second run will tell you that other process is already running).

@misohu misohu requested a review from a team as a code owner June 7, 2024 07:45
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, thanks @misohu !

visualization-server/rockcraft.yaml Show resolved Hide resolved
visualization-server/rockcraft.yaml Show resolved Hide resolved
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @misohu !

@misohu misohu merged commit d65cd0c into main Jun 7, 2024
7 checks passed
@misohu misohu deleted the KF-5701-visualization-server-v-2-2-0 branch June 7, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update visualization-server ROCK
2 participants