Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code to deploy rbac proxy #13

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Add code to deploy rbac proxy #13

merged 2 commits into from
Oct 6, 2023

Conversation

misohu
Copy link
Member

@misohu misohu commented Oct 5, 2023 •
edited
Loading

Fixes #14

The charm was missing kube-rbac-proxy image with setup.

Changes:

  • deploy kube-rbac-proxy
  • rbac-proxy image is correctly set
  • add service for kube-rbac-proxy (same service as operator just another port)
  • add tests

@misohu misohu marked this pull request as ready for review October 5, 2023 12:13
@misohu misohu requested a review from a team as a code owner October 5, 2023 12:13
@misohu
Copy link
Member Author

misohu commented Oct 5, 2023

The publish script will fail as I introduced new image which I need to first upload manually to charmhub ... I will do it after this PR is approved

@DnPlas DnPlas mentioned this pull request Oct 5, 2023
Closed
DnPlas
DnPlas reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comment, other than that LGTM!

src/templates/auth_manifests.yaml.j2 Outdated Show resolved Hide resolved
DnPlas
DnPlas approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @misohu

@misohu misohu merged commit 844678c into main Oct 6, 2023
6 checks passed
@rgildein rgildein deleted the fix-rbac-proxy branch July 17, 2024 14:14
rgildein added a commit that referenced this pull request Jul 17, 2024
@rgildein
Revert "Add code to deploy rbac proxy (#13)"
c99405c 
This reverts commit 844678c.
@rgildein rgildein mentioned this pull request Jul 19, 2024
Merged
rgildein added a commit that referenced this pull request Jul 22, 2024
@rgildein
Add metrics-endpoint and grafana-dashboard (#48)
b7ca895 
* Add metrics-endpoint and grafana-dashboard

Add relation for metrics and dashboards. This is still work in
progress, since metrics are not working for me with kube-rbac-proxy.

fixes: #46

* Revert "Add code to deploy rbac proxy (#13)"

This reverts commit 844678c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DnPlas DnPlas DnPlas approved these changes

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing rbac-proxy in the PvcViewer charm
2 participants
@misohu @DnPlas