Added example on how to use the migrate API #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great addition, thanks. However, please could you re-do your commit with '-s' to sign the commit. The 'lxc' project namespace requires that all commits be "signed off". To so do, you should be able to do something similar to: git commit -s --amend
git push -f <remote-name>This will update the commit, and then update github which will then update the PR. Relevant info for configuring git for signing off is: https://git-scm.com/book/en/v2/Git-Tools-Signing-Your-Work Thanks very much! |
Signed-off-by: gabrik <[email protected]>
…move <container_name> <remote_name>:' behaviour Signed-off-by: gabrik <[email protected]>
…he 'lxc move <container_name> <remote_name>:' behaviour" This reverts commit 1361198. Signed-off-by: gabrik <[email protected]>
lasizoillo
pushed a commit
to lasizoillo/pylxd
that referenced
this pull request
Jul 13, 2018
Signed-off-by: gabrik <[email protected]>
lasizoillo
pushed a commit
to lasizoillo/pylxd
that referenced
this pull request
Jul 13, 2018
Signed-off-by: gabrik <[email protected]> Signed-off-by: lasizoillo <[email protected]>
lasizoillo
pushed a commit
to lasizoillo/pylxd
that referenced
this pull request
Jul 13, 2018
Signed-off-by: gabrik <[email protected]> Signed-off-by: lasizoillo <[email protected]>
e1ee1e11
pushed a commit
to e1ee1e11/pylxd
that referenced
this pull request
Jul 24, 2018
Signed-off-by: gabrik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the example on how to migrate a container using pylxd
As agreed in #315
The migration fails due to an error but the example should be correct