Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage type fixtures #497

Merged

Conversation

atrautsch
Copy link
Contributor

I changed the fixtures and storage volume type to singular.
That should be correct according to the current swagger API example.

However, I do not know if this was always the case.

@stgraber
Copy link
Contributor

Can you edit your commit message to include the Signed-off-by: Firstname Lastname <email> line?

You can usually do so with git commit --amend -s followed by a git push --force

Signed-off-by: atrautsch <[email protected]>
@atrautsch atrautsch force-pushed the bug/496/volume_type_always_custom branch from 5467d90 to 2a917c1 Compare December 31, 2021 09:56
@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021

Codecov Report

Merging #497 (2a917c1) into master (1bbd68e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #497   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files          56       56           
  Lines        4101     4101           
=======================================
  Hits         3981     3981           
  Misses        120      120           
Impacted Files Coverage Δ
pylxd/tests/mock_lxd.py 100.00% <ø> (ø)
pylxd/models/storage_pool.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbd68e...2a917c1. Read the comment docs.

@stgraber stgraber changed the title fixes #496 Fix storage type fixtures Jan 1, 2022
@stgraber stgraber merged commit 903505a into canonical:master Jan 1, 2022
@stgraber
Copy link
Contributor

stgraber commented Jan 1, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants