Merge dnplas-fix-ci into main
#191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent machines (#187) * ci: run integration tests in different machines to avoid deploying seldon twice Building and deploying seldon twice in a row may lead to errors while executing test cases from two different test files. This change ensures each individual test file runs on its own environment. Part of #185 * ci: increase storage of GH runners for integration testing Increasing the storage of the GH runners will avoid potential issues when running integration tests that deploy SeldonDeployments that require a significant amount of them. Part of #185
* tests: remove SeldonDeployments even if the test case fails Using a "remove" fixture we can guarantee that the SeldonDeployment under test is actually removed from the testing environment before proceeding with the test execution. This change prevents potential conflicts when the SeldonDeployment has the same name as a previously deployed one and keeps the testing environment clean before continuing. This commit also moves some of the environment preparations to pytest fixtures to keep the test cases tidy and the test file reusable. Part of #189
…city retries (#190) Increasing the retries and starting time of tenacity retries will ensure the SeldonDeployments can be active and ready to be tested in environments with resources limitations.
* ci, build: update CI, libraries, python dependencies, and format This commit updates the CI with standard CI configuration (juju, actions, deps) that is shared across multiple repositories. All python dependencies are also updated to their latest working versions. This PR also includes library updates. Finally, some formatting was applied on non-compliant files (copyright, style).
phoevos
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge a collection of chores and fixes from dnplas-dev-fix-ci into main. All commits in this PR have been already reviewed, in their respective PRs.
Changes:
Fixes #185 in main
Partially fixes #189 (the test executions are still flaky, see this comment for more reference)