Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add a retry when asserting the up metric #243

Merged
merged 2 commits into from
Feb 23, 2024
Merged

tests: add a retry when asserting the up metric #243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93e5027
tests: add a retry when asserting the up metric
DnPlas Feb 23, 2024
1373963
skip: fix lint
DnPlas Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions tests/integration/test_charm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,20 @@ async def check_alert_propagation(url, alert_name):
assert alert_rule is not None and alert_rule["state"] == "firing"


@tenacity.retry(wait=tenacity.wait_fixed(30), stop=tenacity.stop_after_attempt(6), reraise=True)
async def assert_seldon_unit_is_available(prometheus_url):
"""Assert the unit is available.
This will be tried multiple times to avoid raising errors when prometheus-k8s
is not in an Active status.
"""
# query for the up metric and assert the unit is available
up_query_response = await fetch_url(
f'http://{prometheus_url}:9090/api/v1/query?query=up{{juju_application="{APP_NAME}"}}'
)
assert up_query_response["data"]["result"][0]["value"][1] == "1"


@pytest.mark.abort_on_fail
@pytest.mark.asyncio
async def test_seldon_alert_rules(ops_test: OpsTest):
Expand Down Expand Up @@ -197,12 +211,6 @@ async def test_seldon_alert_rules(ops_test: OpsTest):
discovered_labels = targets_result["data"]["activeTargets"][0]["discoveredLabels"]
assert discovered_labels["juju_application"] == "seldon-controller-manager"

# query for the up metric and assert the unit is available
up_query_response = await fetch_url(
f'http://{prometheus_url}:9090/api/v1/query?query=up{{juju_application="{APP_NAME}"}}'
)
assert up_query_response["data"]["result"][0]["value"][1] == "1"

# obtain alert rules from Prometheus
rules_url = f"http://{prometheus_url}:9090/api/v1/rules"
alert_rules_result = await fetch_url(rules_url)
Expand All @@ -228,6 +236,9 @@ async def test_seldon_alert_rules(ops_test: OpsTest):
for rule in rules:
assert rule["name"] in rules_file_alert_names

# verify SeldonUnitIsUnavailable alert is not firing
await assert_seldon_unit_is_available(prometheus_url)

# The following integration test is optional (experimental) and might not be functioning
# correctly under some conditions due to its reliance on timing of K8S deployments, timing of
# Prometheus scraping, and rate calculations for alerts.
Expand Down
Loading