feat: mlserver sklearn rock #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2023 12:00
canonical/seldon-core-operator#133 Summary of changes: - Created rockcraft file for mlsever-sklearn rock. - Added unit test. - Added tox.ini
Summary of changes: - Use variable ROCK_RUNTIME to simplify development.
i-chvets
changed the title
Summary of changes: - Modified rockcraft.yaml to use environment variables in services instead of calling export in command line.
ca-scribner
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are in canonical/seldon-core-operator#133
Summary of changes:
NOTE: Only limited manual testing was performed as per spec. When integrating with correspoding charm more testing should be peformed via integration tests of the charm.