Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the poetry plugin #5025

Closed
mr-cal opened this issue Sep 9, 2024 · 1 comment · Fixed by #5090
Closed

Enable the poetry plugin #5025

mr-cal opened this issue Sep 9, 2024 · 1 comment · Fixed by #5090
Labels
enhancement New features or optimizations triaged

Comments

@mr-cal
Copy link
Collaborator

mr-cal commented Sep 9, 2024

What needs to get done

Enable the poetry plugin for snapcraft

https://github.com/canonical/snapcraft/blob/main/snapcraft/parts/plugins/python_plugin.py#L49

Why it needs to get done

To allow users to use poetry projects as a source
@mr-cal mr-cal added triaged enhancement New features or optimizations labels Sep 9, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3363.

This message was autogenerated

mr-cal added a commit that referenced this issue Sep 10, 2024
@mr-cal
build(deps): bump craft-parts to 2.1.0
17f9b40 
craft-parts 2.1.0 adds a Poetry plugin. This plugin disabled until
the integration work in #5025 is completed.

Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal added a commit that referenced this issue Sep 10, 2024
@mr-cal
build(deps): bump craft-parts to 2.1.0
63f12fb 
craft-parts 2.1.0 adds a Poetry plugin. This plugin disabled until
the integration work in #5025 is completed.

Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal added a commit that referenced this issue Sep 12, 2024
@mr-cal
build(deps): bump craft-parts to 2.1.0
1b44db7 
craft-parts 2.1.0 adds a Poetry plugin. This plugin disabled until
the integration work in #5025 is completed.

Signed-off-by: Callahan Kovacs <[email protected]>
tigarmo added a commit that referenced this issue Oct 3, 2024
@tigarmo
feat: add Snapcraft-specific Poetry plugin
6d056a6 
The plugin has the same behavior and restrictions as the Python plugin with
regards to base-dependent behavior, symlink handling, etc.

Therefore, this common behavior is extracted into a new "python_common" module,
used by both plugins. This approach is also taken for the reference docs - the
requirement of staging a Python interpreter (or not) is the same for both
plugins.

Enabled for core22 and core24.

Fixes #5025
@tigarmo tigarmo mentioned this issue Oct 3, 2024
Merged
4 tasks
tigarmo added a commit that referenced this issue Oct 3, 2024
@tigarmo
feat: add Snapcraft-specific Poetry plugin
afdcbce 
The plugin has the same behavior and restrictions as the Python plugin with
regards to base-dependent behavior, symlink handling, etc.

Therefore, this common behavior is extracted into a new "python_common" module,
used by both plugins. This approach is also taken for the reference docs - the
requirement of staging a Python interpreter (or not) is the same for both
plugins.

Enabled for core22 and core24.

Fixes #5025
tigarmo added a commit that referenced this issue Oct 3, 2024
@tigarmo
feat: add Snapcraft-specific Poetry plugin
8eb88cb 
The plugin has the same behavior and restrictions as the Python plugin with
regards to base-dependent behavior, symlink handling, etc.

Therefore, this common behavior is extracted into a new "python_common" module,
used by both plugins. This approach is also taken for the reference docs - the
requirement of staging a Python interpreter (or not) is the same for both
plugins.

Enabled for core22 and core24.

Fixes #5025
@tigarmo tigarmo closed this as completed in 5a42f0a Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New features or optimizations triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add Snapcraft-specific Poetry plugin canonical/snapcraft
1 participant
@mr-cal