Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers: allow parallel installations when not running as a snap #4088

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Apr 3, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Minor follow up to #4084 to allow check if snapcraft is running as a snap before reading the envvar SNAP_INSTANCE_NAME.

(CRAFT-1660)

@mr-cal mr-cal force-pushed the parallel-install-envvar-fix branch from e4137a1 to 6b5b486 Compare April 3, 2023 17:41
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Merging #4088 (e4137a1) into main (b852f9a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e4137a1 differs from pull request most recent head 6b5b486. Consider uploading reports for the commit 6b5b486 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4088   +/-   ##
=======================================
  Coverage   94.60%   94.61%           
=======================================
  Files         641      641           
  Lines       51892    51939   +47     
=======================================
+ Hits        49094    49143   +49     
+ Misses       2798     2796    -2     
Impacted Files Coverage Δ
snapcraft/providers.py 97.72% <100.00%> (+0.05%) ⬆️
tests/unit/test_providers.py 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal requested a review from tigarmo April 4, 2023 14:11
@mr-cal mr-cal merged commit cb6f385 into canonical:main Apr 4, 2023
@mr-cal mr-cal deleted the parallel-install-envvar-fix branch April 4, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants