Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): use core24 buildd daily image for devel #4532

Merged
merged 9 commits into from
Feb 13, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jan 22, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

When using build-base: devel, use the core24 buildd daily image instead of the devel daily image.

There is no change in how a user defines their snapcraft.yaml. Once the core24 base is available in the beta channel, then we can allow users to use base: core24.

There are some intermittent problems with launching buildd daily images, see canonical/craft-providers#498.

Fixes #4519
(CRAFT-2390)

@mr-cal
Copy link
Collaborator Author

mr-cal commented Jan 22, 2024

Spread tests failed as-expected:

 * Command that failed: "lxc --project snapcraft launch craft-com.ubuntu.cloud-buildd-daily:core24 local:base-instance-snapcraft-buildd-base-v60--d96bc63e95014eca9a88 --config 'raw.idmap=both 1000 0' --config security.syscalls.intercept.mknod=true --config user.craft_providers.status=STARTING --config user.craft_providers.timer=2024-01-22T16:07:49.707148+00:00 --config user.craft_providers.pid=10360"
* Command exit code: 1
* Command output: b'Creating base-instance-snapcraft-buildd-base-v60--d96bc63e95014eca9a88\n'
* Command standard error output: b"Error: Failed instance creation: Couldn't find the requested image\n"
2024-01-22 16:07:50.803 Full execution log: '/root/.local/state/snapcraft/log/snapcraft-20240122-160748.863418.log'

@mr-cal mr-cal requested review from cmatsuoka, tigarmo and syu-w and removed request for cmatsuoka January 23, 2024 15:28
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89961cf) 89.18% compared to head (a35d542) 89.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4532   +/-   ##
=======================================
  Coverage   89.18%   89.18%           
=======================================
  Files         321      321           
  Lines       21777    21777           
=======================================
  Hits        19421    19421           
  Misses       2356     2356           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-cal
Copy link
Collaborator Author

mr-cal commented Jan 25, 2024

Going to sit on this PR until RT#161719 to be resolved and canonical/craft-providers#501 is landed and released.

@sergiusens sergiusens merged commit a9e12f6 into main Feb 13, 2024
8 of 10 checks passed
@sergiusens sergiusens deleted the CRAFT-2390-use-core24 branch February 13, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use core24 buildd daily image
6 participants