Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde-neon-6: Fix long standing theming issues with Qt snaps. #4884

Merged
merged 9 commits into from
Jul 10, 2024
Merged

kde-neon-6: Fix long standing theming issues with Qt snaps. #4884

merged 9 commits into from
Jul 10, 2024

Conversation

ScarlettGatelyMoore
Copy link
Contributor

  • [x ] Have you followed the guidelines for contributing?
  • [x ] Have you signed the CLA?
  • [x ] Have you successfully run tox run -m lint?
  • [ x] Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Tests pass, there will also come with this a qt-common-themes snap that will hold qt themes and our breeze gtk themes which the consumers will have to connect until I get an auto connect. I will also have to do a MR to remove the non-functional outdated breeze from gtk-common-themes.

@mr-cal mr-cal requested review from lengau and mr-cal July 5, 2024 13:16
mr-cal
mr-cal approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Do you have a link to any issue or bug reports associated with this? I'd like to include some sort of reference in the changelog.

@ScarlettGatelyMoore
Copy link
Contributor Author

Thanks!

Do you have a link to any issue or bug reports associated with this? I'd like to include some sort of reference in the changelog.

https://forum.snapcraft.io/t/icons-theming-and-font-issues-in-qt-snaps-lubuntu/33853
https://forum.snapcraft.io/t/qt-app-and-qt-and-kvantum-themes/15234
https://forum.snapcraft.io/t/how-to-fix-weird-cursor-theme-and-fonts-in-qt-apps-on-elementary-or-other-distribution-solution/10248
https://forum.snapcraft.io/t/theme-issue-with-content-snap/13005
https://bugs.launchpad.net/snappy/+bug/1836054
https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1585332

Just to name a few...

@mr-cal mr-cal merged commit fb1834c into canonical:main Jul 10, 2024
10 checks passed
farshidtz pushed a commit to farshidtz/snapcraft that referenced this pull request Jul 18, 2024
@ScarlettGatelyMoore @farshidtz
feat(extensions): add content interfaces for qt-common-themes to KDE …
437c71f 
…Neon 6 (canonical#4884)
farshidtz added a commit to farshidtz/snapcraft that referenced this pull request Jul 18, 2024
@farshidtz
Squashed commit of the following:
f08d6e3 
commit d65754b
Author: Callahan Kovacs <[email protected]>
Date:   Wed Jul 17 10:57:51 2024 -0500

    feat(extensions): pass app name to `get_app_snippet()`

    Signed-off-by: Callahan Kovacs <[email protected]>

commit fa1043d
Author: Callahan <[email protected]>
Date:   Tue Jul 16 13:56:22 2024 -0500

    tests: disable `build-base: devel` spread tests (canonical#4922)

    Disable `build-base: devel` spread tests until we have the resources to
    debug the underlying issue with 24.10 buildd images and
    `systemd-resolved` (canonical#4921).

    We should be able to address this issue in 2024-Nov.

    Fixes canonical#4910
    (CRAFT-3105)

    Signed-off-by: Callahan Kovacs <[email protected]>

commit de7f1d5
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Jul 15 17:36:49 2024 -0500

    build(deps): bump zipp from 3.17.0 to 3.19.1 (canonical#4901)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit ccbc7b3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Jul 15 14:27:32 2024 -0500

    build(deps): bump certifi from 2023.7.22 to 2024.7.4 in /docs/.sphinx (canonical#4903)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Callahan <[email protected]>

commit 91fa63c
Author: Callahan <[email protected]>
Date:   Mon Jul 15 07:11:41 2024 -0500

    docs: add explanation, reference, and how to for bases (canonical#4900)

    Signed-off-by: Callahan Kovacs <[email protected]>

commit 011dd11
Author: Callahan <[email protected]>
Date:   Fri Jul 12 16:15:52 2024 -0500

    docs: add explanation, how-to, and reference for components (canonical#4904)

    Signed-off-by: Callahan Kovacs <[email protected]>

commit f313611
Author: Sergio Schvezov <[email protected]>
Date:   Wed Jul 10 16:07:49 2024 -0300

    chore: add sorted flake8 and pylint for tiobe/tics

    Sorting proved useful in removing dups like pycodestyle

commit 6cbdff6
Author: Sergio Schvezov <[email protected]>
Date:   Wed Jul 10 15:03:33 2024 -0300

    ci: use native Ubuntu python for tests

    Signed-off-by: Sergio Schvezov <[email protected]>

commit fb1834c
Author: Scarlett Gately Moore <[email protected]>
Date:   Wed Jul 10 12:18:14 2024 -0700

    feat(extensions): add content interfaces for qt-common-themes to KDE Neon 6 (canonical#4884)

commit ccba428
Author: Sergio Schvezov <[email protected]>
Date:   Wed Jul 10 14:01:53 2024 -0300

    ci: use correct attribute for tics workflow (canonical#4906)

commit 74b7b75
Author: Sergio Schvezov <[email protected]>
Date:   Wed Jul 10 09:28:36 2024 -0300

    ci: set the branchdir for TICS

commit 0668b6c
Author: Sergio Schvezov <[email protected]>
Date:   Mon Jul 8 16:55:44 2024 -0300

    fix: setup Python env for tiobe ci

    Also shallow checkout like the other workflows

commit a4e2895
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Jul 8 12:55:02 2024 -0500

    build(deps): bump certifi from 2023.11.17 to 2024.7.4 (canonical#4896)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 1d17810
Author: Callahan <[email protected]>
Date:   Mon Jul 8 08:37:34 2024 -0500

    build(deps): add 'validators' to install_requires (canonical#4898)

    `validators` was added in canonical#4888 to the requirement files but
    not to `setup.py`

    Signed-off-by: Callahan Kovacs <[email protected]>

commit d9c8781
Author: Callahan <[email protected]>
Date:   Fri Jul 5 22:24:52 2024 -0500

    fix(remotebuild): require core20 snaps to use the legacy remote builder (canonical#4895)

    Requires core20 snaps to use the legacy remote builder because the new
    remote builder cannot parse core20 `snapcraft.yaml` files (canonical#4885).

    Signed-off-by: Callahan Kovacs <[email protected]>

commit 124c932
Author: Callahan Kovacs <[email protected]>
Date:   Tue Jul 2 15:48:31 2024 -0500

    tests(remotebuild): add per-base remote-build spread tests

    Signed-off-by: Callahan Kovacs <[email protected]>

commit 3325af0
Author: Callahan Kovacs <[email protected]>
Date:   Wed Jul 3 13:30:06 2024 -0500

    feat(remotebuild): allow build-for all

    Signed-off-by: Callahan Kovacs <[email protected]>

commit c1c70a2
Author: Callahan Kovacs <[email protected]>
Date:   Tue Jul 2 14:37:49 2024 -0500

    fix(remotebuild): use legacy launchpad credentials if they exist

    If the legacy remote-build credentials exist and the new credentials do
    not, emit a deprecation warning and use the legacy credentials.

    Signed-off-by: Callahan Kovacs <[email protected]>

commit 4bb948b
Author: Callahan Kovacs <[email protected]>
Date:   Tue Jul 2 12:41:40 2024 -0500

    build(deps): bump craft libraries

commit fad8df3
Author: সৌম্যদীপ ঘোষ <[email protected]>
Date:   Sat Jul 6 00:46:47 2024 +0530

    fix: validate appstream metadata links and prefer links from project metadata (canonical#4888)

    - Validate that update_contact, donation, vcs-browser, bugtracker, and homepage
      fields adopted from an appstream metadata file are valid URLs or email addresses.
    - Contact, donation, source-code, issues, and website fields in a snapcraft.yaml take
      priority over appstream metadata

commit 4f3c19d
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Jul 2 14:20:18 2024 -0400

    build(deps): bump urllib3 from 1.26.18 to 1.26.19 in /docs/.sphinx (canonical#4887)
@mr-cal mr-cal mentioned this pull request Jul 31, 2024
Merged
4 tasks
@mr-cal
Copy link
Collaborator

mr-cal commented Sep 3, 2024

This needs more auto-connect permissions, see discussion in the forum: https://forum.snapcraft.io/t/kde-global-auto-connect-qt-common-themes/40878

@ScarlettGatelyMoore
Copy link
Contributor Author

This needs more auto-connect permissions, see discussion in the forum: https://forum.snapcraft.io/t/kde-global-auto-connect-qt-common-themes/40878

I don't follow. They rejected my requests and told me to make snaps for our themes. I do need to update the extension, but I won't be able to get to it for another week or so.

@mr-cal
Copy link
Collaborator

mr-cal commented Sep 3, 2024 •
edited
Loading

Sorry, that was a general note to link to that forum post, not a request for you.

I'm trying to decide if this should be in Snapcraft 8.4 or delayed until 8.5.

@ScarlettGatelyMoore
Copy link
Contributor Author

Sorry, that was a general note to link to that forum post, not a request for you.

I'm trying to decide if this should be in Snapcraft 8.4 or delayed until 8.5.

I would delay it as I don't have qt themes working. The gtk themes mostly work as snaps.

@mr-cal
Copy link
Collaborator

mr-cal commented Sep 3, 2024

Sounds good, thanks for your opinion.

I'll plan to revert this in a hotfix/8.4 branch and leave it in main.

mr-cal added a commit that referenced this pull request Sep 5, 2024
@mr-cal
Revert "feat(extensions): add content interfaces for qt-common-themes…
610f2aa 
… to KDE Neon 6 (#4884)"

This is a temporary revert of fb1834c,
pending design changes to icon theming across the snap ecosystem.
@mr-cal mr-cal mentioned this pull request Sep 5, 2024
Merged
4 tasks
lengau pushed a commit that referenced this pull request Sep 6, 2024
@mr-cal
chore(revert): add content interfaces for qt-common-themes (#5013)
ec1cc0a 
This is a temporary revert of #4884 for `hotfix/8.4` to allow releasing
snapcraft 8.4.

See the discussion in #4884 and [this forum
post](https://forum.snapcraft.io/t/kde-global-auto-connect-qt-common-themes/40878)
for context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiusens sergiusens sergiusens left review comments

@mr-cal mr-cal mr-cal approved these changes

@lengau lengau lengau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScarlettGatelyMoore @mr-cal @sergiusens @lengau