Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: extension env-injector #4925
base: main
Are you sure you want to change the base?
add: extension env-injector #4925
Changes from all commits
1689d29
c439436
774f067
04dd07e
a6374ac
0a280d9
2d276b8
d0629a7
8bd2300
d8f9e68
3e17cec
b65a0c6
6ab0b23
09a883a
84ce910
984dd5b
5406f55
9466377
bd60e48
03a188d
0d09a15
18d6c5c
7bc6f24
0c57814
cb72589
297de3a
6b1dafe
498ad20
5e15598
c20cac8
e30ed89
645fb35
d839fe2
76e51e6
ecbde85
48378ca
0ce514a
a97df2d
b5f6370
fb432b8
01c5c25
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very simple snippet and snap authors are quite used to apply even more complex patterns to parts or applications in order to implement certain features, so this alone may not warrant the existence of an extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The selected snippet adds the env exporter program and the alias. The alias gets added only when the user hasn't set it (this is intended and based on snapcraft's internal handling of the dictionary).
The extension does more than that: It adds the source code for the exporter program, builds it and places it in the right location. The design also envisions additional functions, such as adding a configure hook when it isn't a present, or adding configuration validation.
If this was to be done manually, without the extension, the developers would have to:
i. Add the exporter program to the command chain
ii. Set the application alias
In comparison, when the extension is used:
The manual way requires average snapping knowledge, which early adopters lack. I'd emphasize that the goal is to simplify the snapping of apps and all this complexity thrown at the developer defeats its purpose.
* We could make a snap or a debian package and let the developer stage it, but then we need to separately maintain that package.