Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configcore: allow to run core configuration on classic via env #12607

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Feb 28, 2023

This commit adds a new environment called
SNAPD_BREAK_SYSTEM_BY_RUNNING_CORE_ONLY_CONFIG
that allows to run core configuration options on classic.

The goal is to be able to test netplan integration on classic systems. Nothing in netplan is core specific, we just did not enable it on classic for conistency but it should be great for netplan based integration testing inside the netplan repo.

@mvo5 mvo5 requested a review from pedronis February 28, 2023 17:39
@github-actions github-actions bot added the Needs Documentation -auto- Label automatically added which indicates the change needs documentation label Feb 28, 2023
This commit adds a new environment called
`SNAPD_BREAK_SYSTEM_BY_RUNNING_CORE_ONLY_CONFIG`
that allows to run core configuration options on classic.

The goal is to be able to test netplan integration on classic
systems. Nothing in netplan is core specific, we just did not
enable it on classic for conistency but it should be great
for netplan based integration testing inside the netplan repo.
@mvo5 mvo5 force-pushed the add-test-options-for-core-config-on-classic branch from 4bdf7be to 81a9e3a Compare February 28, 2023 19:16
@pedronis
Copy link
Collaborator

pedronis commented Mar 1, 2023

discussed my preferred approach with @mvo5, we preferably want to force enable specific option/option groups and not all of them

@mvo5 mvo5 removed the request for review from pedronis March 8, 2023 11:01
@mvo5 mvo5 added the Precious but later ❤️ PRs that are precious but can't be worked on right now and should be reopened at a later point label Oct 12, 2023
@mvo5 mvo5 closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation -auto- Label automatically added which indicates the change needs documentation Precious but later ❤️ PRs that are precious but can't be worked on right now and should be reopened at a later point
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants