add: bash snappy-env exporter #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farshidtz
reviewed
Sep 2, 2024
Signed-off-by: Lincoln Wallace <[email protected]>
locnnil
force-pushed
the
bash-exporter
branch
from
7e90fec
to
b75d2da
Compare
farshidtz
requested changes
Sep 2, 2024
Signed-off-by: Lincoln Wallace <[email protected]>
farshidtz
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Thanks. This has been reviewed in
- add: env-exposer program and reference test snap locnnil/env-injector#1
- Simplify, add alias support locnnil/env-injector#2
One known issue is the lack of validation for value types. The program exports unexpected values if the user sets an object as value, e.g. env.x.y="value" which is equivalent to env.x={"y":"value"}. I'll file an issue with better examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bash version of snappy-env exporter program.