Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refinements for fw updates #103

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Refinements for fw updates #103

merged 5 commits into from
Sep 27, 2023

Conversation

nancyc12
Copy link
Contributor

@nancyc12 nancyc12 commented Sep 25, 2023 •
edited
Loading

changes:

  1. shorten the import path in patch() in test files
  2. increase LVFSDevice reboot timeout
  3. fix optional parameters for detect_device()
  4. update README file type to .md

nadzyah
nadzyah requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@nadzyah nadzyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes, just one suggestion to improve the code

extras/devices/LVFS/__init__.py Outdated Show resolved Hide resolved
nadzyah
nadzyah reviewed Sep 26, 2023
View reviewed changes
extras/devices/__init__.py Outdated Show resolved Hide resolved
@nancyc12 nancyc12 merged commit edea55d into main Sep 27, 2023
3 checks passed
@nancyc12 nancyc12 deleted the add-fw-scripts branch September 27, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadzyah nadzyah nadzyah approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nancyc12 @nadzyah