-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move testflinger-server code to monorepo layout #131
Conversation
Convert to using pyproject.toml
Fix changes requested by new version of black formatting
Improve handling of maas errors and a few more pylint cleanups
Remove currently unused logstash support
Pylint sda init
Fix a few use-dict-literal warnings from pylint
Break out code to update results from the phase from run_test_phase
Remove rpi3 device agent since we use muxpi instead now
Convert to using pyproject.toml for setup
ed91f7f
to
acd7923
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit of bike-shedding - I feel like the testflinger-
prefix on all the component sub directories is redundant. Should we remove it?
Just to clarify, do you mean just from the directory name? For instance, things like "testflinger-agent" or especially the user facing "testflinger-cli" would be a little confusing if you executed them as just "agent" or "cli". So I think internally, keeping testflinger as part of the name is ok. I'm ok with removing it from the names of the directories if you think that looks cleaner though. The directory structure would then look like this: |
Yes, just meant the directory name |
08575a3
to
14c90c2
Compare
14c90c2
to
6d1c66c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me.
I think there is some cruft from old repositories (e.g. pmr-merge-hooks), but happy for the merge to proceed with what is in the source repos now and tidy these things up in later PRs.
Description
This moves the testflinger-server code into the structure that we need for monorepo
Resolved issues
CERTTF-166 (partially)
Documentation
Docs directory already exists and was moved to the root of the monorepo along with the .readthedocs.yaml
Tests
In progress...