Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send all queues in agent data #148

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Send all queues in agent data #148

merged 3 commits into from
Oct 31, 2023

Conversation

plars
Copy link
Collaborator

@plars plars commented Oct 26, 2023

Description

  • Send all known queues for the agent instead of just the advertised ones to the server for the initial_agent_data
  • Modify the agent_detail page so that it displays all of these queues for each agent, along with a link to the queue details page
  • BONUS small change to speed up test_agent.py execution significantly (from 161s to 16s on my system)

Resolved issues

Fixes CERTTF-141

Documentation

N/A

Tests

Unit test added for this method, and I also set it up locally and connected an agent to it so that I could see the change to the html. Here's an example of what it looks like:
image

@plars plars requested a review from a team October 26, 2023 22:11
@plars plars force-pushed the send_all_queues_in_agent_data branch from af94a72 to 7da191b Compare October 31, 2023 15:22
@plars plars force-pushed the send_all_queues_in_agent_data branch from 7da191b to 47b1a2e Compare October 31, 2023 16:18
@plars plars requested a review from omar-selo October 31, 2023 16:27
nadzyah
nadzyah approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@nadzyah nadzyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look clear to me. I don't have any questions about them

@plars plars merged commit a669c17 into main Oct 31, 2023
6 checks passed
@plars plars deleted the send_all_queues_in_agent_data branch October 31, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadzyah nadzyah nadzyah approved these changes

@omar-selo omar-selo Awaiting requested review from omar-selo

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plars @omar-selo @nadzyah