Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api to allow retrieving agent data #171

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add api to allow retrieving agent data #171

merged 1 commit into from
Dec 12, 2023

Conversation

plars
Copy link
Collaborator

@plars plars commented Dec 9, 2023

Description

Add api to allow retrieving agent data

Resolved issues

Resolves CERTTF-246

Documentation

swagger docs and README updated

Tests

Unit test added

@plars plars requested a review from a team December 9, 2023 16:53
Copy link

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed CERTTF-246 mentions a query parameter ?identifier=<cid>. Is this no longer necessary or perhaps it's coming in a future PR?

server/tests/test_v1.py Show resolved Hide resolved
server/src/api/schemas.py Show resolved Hide resolved
@plars
Copy link
Collaborator Author

plars commented Dec 11, 2023

I've noticed CERTTF-246 mentions a query parameter ?identifier=<cid>. Is this no longer necessary or perhaps it's coming in a future PR?

My understanding of the problem at the time we wrote that, was that they simply wanted to see if it was in testflinger or not on the c3 machine details page. After more discussion, it sounds like what they actually want is to extend the search API in a way that allows them to also query for systems that are in testflinger and retrieve the list of valid queues for that device as well. So eventually the solution will likely look more like what we discussed at the sprint - where c3 knows everything about every device, and testflinger generates configs for devices based off that data rather than through cc-lab-manager. But that will take quite a bit of time to implement. For now, this gives us a way that we can bulk-import the necessary data about agents so that c3 has more awareness and can hopefully include this in search results.

Copy link

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your detailed responses!

@plars plars merged commit d37d069 into main Dec 12, 2023
3 checks passed
@plars plars deleted the server-get-agent-data branch December 12, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants