Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MarkupSafe to version 2.0.1 #11261

Closed
wants to merge 1 commit into from

Conversation

mtruj013
Copy link
Contributor

Done

  • Set MarkupSafe to version 2.0.1

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • See that the site runs correctly

Issue / Card

Fixes #11260

@webteam-app
Copy link

Demo starting at https://ubuntu-com-11261.demos.haus

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #11261 (e0562ff) into main (573612a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #11261   +/-   ##
=======================================
  Coverage   58.68%   58.68%           
=======================================
  Files         109      109           
  Lines        2544     2544           
  Branches      708      708           
=======================================
  Hits         1493     1493           
  Misses        990      990           
  Partials       61       61           

@@ -1,3 +1,4 @@
MarkupSafe==2.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move it below flask-base? we had issues before, whereas the module on top overrode the Python version of the rest of the modules. This way we ensure that the flask-base Python version is the one we use.

@nottrobin
Copy link
Contributor

Fixed in #11259 instead

@nottrobin nottrobin closed this Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MarkupSafe has released a breaking change
4 participants