Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] fix validation/help message margin top for dense elements #5101

Closed
wants to merge 2 commits into from

Conversation

pierre-H
Copy link

@pierre-H pierre-H commented May 26, 2024

Done

When an element is dense, the thelp text or the validation text has a top margin, which should be disabled.

QA

  • Open demo
  • [Add QA steps]
  • Review updated documentation:
    • [List any updated documentation for review]

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Fix :
image

image

@webteam-app
Copy link

pierre-H is not a collaborator of the repo

@bartaz
Copy link
Member

bartaz commented May 29, 2024

@pierre-H Hey, thanks for your contribution.

Indeed the validation message does not work well with dense inputs. But because the issue is with validation message (and help text), I think it would be better if it's solved in those respecitive places.

So you would need to modify _patterns_form-help-text.scss and _patterns_form-validation.scss instead.

@bartaz
Copy link
Member

bartaz commented Jul 29, 2024

This got stale, opened it up as a bug: #5262

Closing PR for now.

@bartaz bartaz closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants