Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invite Notification #31

Merged
merged 8 commits into from
Jul 13, 2023
Merged

Invite Notification #31

merged 8 commits into from
Jul 13, 2023

Conversation

cp-pratik-k
Copy link
Collaborator

@cp-pratik-k cp-pratik-k commented Jul 4, 2023 •
edited
Loading

Purpose

  • User shoud be able to get notification if its invited on space.
  • Hr should be able to get notification about invite accept.

Summary of Changes

  • Add implementation for invite notification service
  • Add implementation for send invitation notification to user
  • Add implementation for send invitation accept notification to hr.

Test steps

  • Run flutter test

Conformity

  • Followed git guidelines for creating commit messages and Pull Request guidelines.
  • Self-approved the PR - reviewed the PR as a reviewer and gave it self-approval if everything is ok. If not, made the required changes.
  • Ensured that the PR satisfies all specified requirements in the ticket, including bug fixes and new features.
  • Provided test steps, including steps to reproduce the issue or test the new functionality, ensuring other team members can verify the changes.
  • Added/Updated proper code comments to make it easy-to-understand for other developers.
  • Reused code (if the same code was written twice, made it common and reused it at both places).
  • Removed unused or commented code if not required.
  • Ensured proper Dart naming conventions were used for variables, classes, and methods.
  • Localized user-facing strings.
  • Included screenshots/videos of behavior changes: Provided visual evidence of any changes to UI or behavior for easier review and understanding in the PR description.
  • Implemented proper error handling: Ensured that the code anticipated and handled potential errors and edge cases gracefully.
  • Avoided introducing technical debt: If the PR introduces technical debt, created and linked appropriate tickets for future resolution.
  • Included relevant unit tests: Wrote unit tests that focused on testing behavior and functionality, rather than merely covering lines of code.
  • Ensured code was performant and scalable: Verified that the changes did not introduce performance issues or bottlenecks and could scale as needed.
  • Ensured comments were up-to-date and relevant to the code to describe complex logic and to add understanding for other developers.
  • Marked the PR as ready before submitting it for review.

@cp-pratik-k cp-pratik-k changed the title Add implementation for invite notification Invite Notification Jul 5, 2023
cp-sneha-s
cp-sneha-s previously approved these changes Jul 5, 2023
View reviewed changes
@cp-pratik-k
add crashlitics logs for notification error
8689248
@cp-pratik-k
Disable firebase crashlytics for debug mode
d2ecf65
@cp-pratik-k
Merge branch 'main' into invite-notification
7eebb80 
# Conflicts:
#	test/unit_test/admin/home/search_member/invite_member_bloc_test.mocks.dart
#	test/unit_test/space/join_space/join_space_test.mocks.dart
@cp-pratik-k
Add log on notification sent
db6d573
@cp-sneha-s cp-sneha-s merged commit 9de4c1e into main Jul 13, 2023
1 check passed
@cp-sneha-s cp-sneha-s deleted the invite-notification branch January 17, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cp-sneha-s cp-sneha-s cp-sneha-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cp-pratik-k @cp-sneha-s