test: add UTs for network hotplug

add UTs for network hotplug related fuctions Fixes kata-containers#113 Signed-off-by: Ruidong Cao <[email protected]>
caoruidong · Aug 16, 2018 · 8eed692 · 8eed692
1 parent 72df219
commit 8eed692
Show file tree

Hide file tree

Showing 7 changed files with 384 additions and 0 deletions.
diff --git a/cli/network_test.go b/cli/network_test.go
@@ -0,0 +1,88 @@
+// Copyright (c) 2018 Huawei Corporation.
+//
+// SPDX-License-Identifier: Apache-2.0
+//
+
+package main
+
+import (
+	"flag"
+	"io/ioutil"
+	"os"
+	"testing"
+
+	"github.com/kata-containers/agent/protocols/grpc"
+	vc "github.com/kata-containers/runtime/virtcontainers"
+	"github.com/stretchr/testify/assert"
+)
+
+var (
+	testAddInterfaceFuncReturnNil = func(sandboxID string, inf *grpc.Interface) (*grpc.Interface, error) {
+		return nil, nil
+	}
+	testRemoveInterfaceFuncReturnNil = func(sandboxID string, inf *grpc.Interface) (*grpc.Interface, error) {
+		return nil, nil
+	}
+	testListInterfacesFuncReturnNil = func(sandboxID string) ([]*grpc.Interface, error) {
+		return nil, nil
+	}
+	testUpdateRoutsFuncReturnNil = func(sandboxID string, routes []*grpc.Route) ([]*grpc.Route, error) {
+		return nil, nil
+	}
+	testListRoutesFuncReturnNil = func(sandboxID string) ([]*grpc.Route, error) {
+		return nil, nil
+	}
+)
+
+func TestNetworkCliFunction(t *testing.T) {
+	assert := assert.New(t)
+
+	state := vc.State{
+		State: vc.StateRunning,
+	}
+
+	testingImpl.AddInterfaceFunc = testAddInterfaceFuncReturnNil
+	testingImpl.RemoveInterfaceFunc = testRemoveInterfaceFuncReturnNil
+	testingImpl.ListInterfacesFunc = testListInterfacesFuncReturnNil
+	testingImpl.UpdateRoutesFunc = testUpdateRoutsFuncReturnNil
+	testingImpl.ListRoutesFunc = testListRoutesFuncReturnNil
+
+	path, err := createTempContainerIDMapping(testContainerID, testSandboxID)
+	assert.NoError(err)
+	defer os.RemoveAll(path)
+
+	testingImpl.StatusContainerFunc = func(sandboxID, containerID string) (vc.ContainerStatus, error) {
+		return newSingleContainerStatus(testContainerID, state, map[string]string{}), nil
+	}
+
+	defer func() {
+		testingImpl.AddInterfaceFunc = nil
+		testingImpl.RemoveInterfaceFunc = nil
+		testingImpl.ListInterfacesFunc = nil
+		testingImpl.UpdateRoutesFunc = nil
+		testingImpl.ListRoutesFunc = nil
+		testingImpl.StatusContainerFunc = nil
+	}()
+
+	set := flag.NewFlagSet("", 0)
+	execCLICommandFunc(assert, addIfaceCommand, set, true)
+
+	set.Parse([]string{testContainerID})
+	execCLICommandFunc(assert, listIfacesCommand, set, false)
+	execCLICommandFunc(assert, listRoutesCommand, set, false)
+
+	f, err := ioutil.TempFile("", "interface")
+	defer os.Remove(f.Name())
+	assert.NoError(err)
+	assert.NotNil(f)
+	f.WriteString("{}")
+
+	set.Parse([]string{testContainerID, f.Name()})
+	execCLICommandFunc(assert, addIfaceCommand, set, false)
+	execCLICommandFunc(assert, delIfaceCommand, set, false)
+
+	f.Seek(0, 0)
+	f.WriteString("[{}]")
+	f.Close()
+	execCLICommandFunc(assert, updateRoutesCommand, set, false)
+}
diff --git a/virtcontainers/api_test.go b/virtcontainers/api_test.go
@@ -16,6 +16,7 @@ import (
 	"syscall"
 	"testing"
 
+	"github.com/kata-containers/agent/protocols/grpc"
 	"github.com/kata-containers/runtime/virtcontainers/pkg/mock"
 	specs "github.com/opencontainers/runtime-spec/specs-go"
 	"github.com/stretchr/testify/assert"
@@ -2349,3 +2350,41 @@ func TestPauseResumeContainer(t *testing.T) {
 	err = ResumeContainer(s.ID(), contID)
 	assert.NoError(err)
 }
+
+func TestNetworkOperation(t *testing.T) {
+	if os.Geteuid() != 0 {
+		t.Skip(testDisabledAsNonRoot)
+	}
+
+	cleanUp()
+
+	assert := assert.New(t)
+	inf := &grpc.Interface{}
+
+	_, err := AddInterface("", inf)
+	assert.Error(err)
+
+	_, err = AddInterface("abc", inf)
+	assert.Error(err)
+
+	config := newTestSandboxConfigNoop()
+
+	s, _, err := createAndStartSandbox(config)
+	assert.NoError(err)
+	assert.NotNil(s)
+
+	_, err = AddInterface(s.ID(), inf)
+	assert.Error(err)
+
+	_, err = RemoveInterface(s.ID(), inf)
+	assert.NoError(err)
+
+	_, err = ListInterfaces(s.ID())
+	assert.NoError(err)
+
+	_, err = UpdateRoutes(s.ID(), nil)
+	assert.NoError(err)
+
+	_, err = ListRoutes(s.ID())
+	assert.NoError(err)
+}
diff --git a/virtcontainers/hyperstart_agent_test.go b/virtcontainers/hyperstart_agent_test.go
@@ -206,3 +206,35 @@ func TestHyperReseedAPI(t *testing.T) {
 	err := h.reseedRNG([]byte{})
 	assert.Nil(err)
 }
+
+func TestHyperUpdateInterface(t *testing.T) {
+	assert := assert.New(t)
+
+	h := &hyper{}
+	_, err := h.updateInterface(nil)
+	assert.Nil(err)
+}
+
+func TestHyperListInterfaces(t *testing.T) {
+	assert := assert.New(t)
+
+	h := &hyper{}
+	_, err := h.listInterfaces()
+	assert.Nil(err)
+}
+
+func TestHyperUpdateRoutes(t *testing.T) {
+	assert := assert.New(t)
+
+	h := &hyper{}
+	_, err := h.updateRoutes(nil)
+	assert.Nil(err)
+}
+
+func TestHyperListRoutes(t *testing.T) {
+	assert := assert.New(t)
+
+	h := &hyper{}
+	_, err := h.listRoutes()
+	assert.Nil(err)
+}
diff --git a/virtcontainers/kata_agent_test.go b/virtcontainers/kata_agent_test.go
@@ -201,6 +201,14 @@ func (p *gRPCProxy) UpdateRoutes(ctx context.Context, req *pb.UpdateRoutesReques
 	return nil, nil
 }
 
+func (p *gRPCProxy) ListInterfaces(ctx context.Context, req *pb.ListInterfacesRequest) (*pb.Interfaces, error) {
+	return nil, nil
+}
+
+func (p *gRPCProxy) ListRoutes(ctx context.Context, req *pb.ListRoutesRequest) (*pb.Routes, error) {
+	return nil, nil
+}
+
 func (p *gRPCProxy) OnlineCPUMem(ctx context.Context, req *pb.OnlineCPUMemRequest) (*gpb.Empty, error) {
 	return emptyResp, nil
 }

diff --git a/virtcontainers/network_test.go b/virtcontainers/network_test.go
@@ -480,6 +480,60 @@ func TestVhostUserEndpointAttach(t *testing.T) {
 	}
 }
 
+func TestVhostUserEndpoint_HotAttach(t *testing.T) {
+	assert := assert.New(t)
+	v := &VhostUserEndpoint{
+		SocketPath:   "/tmp/sock",
+		HardAddr:     "mac-addr",
+		EndpointType: VhostUserEndpointType,
+	}
+
+	h := &mockHypervisor{}
+
+	err := v.HotAttach(h)
+	assert.Error(err)
+}
+
+func TestVhostUserEndpoint_HotDetach(t *testing.T) {
+	assert := assert.New(t)
+	v := &VhostUserEndpoint{
+		SocketPath:   "/tmp/sock",
+		HardAddr:     "mac-addr",
+		EndpointType: VhostUserEndpointType,
+	}
+
+	h := &mockHypervisor{}
+
+	err := v.HotDetach(h, true, "")
+	assert.Error(err)
+}
+
+func TestPhysicalEndpoint_HotAttach(t *testing.T) {
+	assert := assert.New(t)
+	v := &PhysicalEndpoint{
+		IfaceName: "eth0",
+		HardAddr:  net.HardwareAddr{0x02, 0x00, 0xca, 0xfe, 0x00, 0x04}.String(),
+	}
+
+	h := &mockHypervisor{}
+
+	err := v.HotAttach(h)
+	assert.Error(err)
+}
+
+func TestPhysicalEndpoint_HotDetach(t *testing.T) {
+	assert := assert.New(t)
+	v := &PhysicalEndpoint{
+		IfaceName: "eth0",
+		HardAddr:  net.HardwareAddr{0x02, 0x00, 0xca, 0xfe, 0x00, 0x04}.String(),
+	}
+
+	h := &mockHypervisor{}
+
+	err := v.HotDetach(h, true, "")
+	assert.Error(err)
+}
+
 func TestGetNetNsFromBindMount(t *testing.T) {
 	assert := assert.New(t)
 

diff --git a/virtcontainers/noop_agent_test.go b/virtcontainers/noop_agent_test.go
@@ -217,3 +217,35 @@ func TestNoopAgentReseedRNG(t *testing.T) {
 		t.Fatal("reseedRNG failed")
 	}
 }
+
+func TestNoopAgentUpdateInterface(t *testing.T) {
+	n := &noopAgent{}
+	_, err := n.updateInterface(nil)
+	if err != nil {
+		t.Fatal("updateInterface failed")
+	}
+}
+
+func TestNoopAgentListInterfaces(t *testing.T) {
+	n := &noopAgent{}
+	_, err := n.listInterfaces()
+	if err != nil {
+		t.Fatal("listInterfaces failed")
+	}
+}
+
+func TestNoopAgentUpdateRoutes(t *testing.T) {
+	n := &noopAgent{}
+	_, err := n.updateRoutes(nil)
+	if err != nil {
+		t.Fatal("updateRoutes failed")
+	}
+}
+
+func TestNoopAgentListRoutes(t *testing.T) {
+	n := &noopAgent{}
+	_, err := n.listRoutes()
+	if err != nil {
+		t.Fatal("listRoutes failed")
+	}
+}