Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation/build issue with 1.0.2 #18

Closed
arendjantetteroo opened this issue Oct 31, 2022 · 3 comments
Closed

Installation/build issue with 1.0.2 #18

arendjantetteroo opened this issue Oct 31, 2022 · 3 comments
Assignees
Labels
bug Something isn't working priority
Milestone

Comments

@arendjantetteroo
Copy link

arendjantetteroo commented Oct 31, 2022

Describe the bug
Installation of 1.0.2 fails due to type: "module" in package.json.
Possibly related to the use of typescript in a nextjs project.

To Reproduce
See reproducer at https://github.com/arendjantetteroo/capacitor-file-opener-bug
Steps to reproduce are in the readme

Expected behavior
Can be used as 1.0.1 was.

Screenshots

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser all
  • Version

Smartphone (please complete the following information):
N/A

Additional context
Add any other context about the problem here.

@ryaa
Copy link
Member

ryaa commented Nov 1, 2022

Thank you for the additional details. I confirm the problem and made the required fix - see #19. Can you please install the version of the plugin with the fix and see if it helps. To install please issue the below command:
npm install capacitor-community/file-opener#bugfix/build-1.0.2-fails-to-install-in-nextjs-project-with-dist

NOTE: i could successfully build and run you app with my change and the initial error is gone. However there is another one but I assume that this is not related to the file-opener plugin - see below
Screen Shot 2022-11-01 at 09 47 23

@arendjantetteroo
Copy link
Author

Thanks @ryaa i can confirm it now properly builds with this fix.

The captureException error is due to sentry js missing, i just copied the smallest code to show the error. This is indeed not related and can be ignored.

@ryaa ryaa added this to the v1.0.3 milestone Nov 1, 2022
@ryaa
Copy link
Member

ryaa commented Nov 1, 2022

The fix will be included into v1.0.3

@ryaa ryaa closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority
Projects
None yet
Development

No branches or pull requests

2 participants