fix(crashlytics): crash(...) method now respects message option (#721)

* bugfix-firebase-crashlytics-iOS-testCrash-not-passing-message-option-#720 * npm run changeset * Update thin-hornets-explain.md --------- Co-authored-by: Robin Genz <[email protected]>
capawesome-team · Sep 20, 2024 · 8b190d1 · 8b190d1
1 parent fd2ee14
commit 8b190d1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/.changeset/thin-hornets-explain.md b/.changeset/thin-hornets-explain.md
@@ -0,0 +1,5 @@
+---
+'@capacitor-firebase/crashlytics': patch
+---
+
+fix(ios): `crash(...)` method now respects message option
diff --git a/packages/crashlytics/ios/Plugin/FirebaseCrashlytics.swift b/packages/crashlytics/ios/Plugin/FirebaseCrashlytics.swift
@@ -10,8 +10,8 @@ import FirebaseCrashlytics
         }
     }
 
-    @objc public func crash() {
-        fatalError()
+    @objc public func crash(_ message: String) {
+        fatalError(message)
     }
 
     @objc func setCustomKey(_ key: String, _ type: String, _ call: CAPPluginCall) {

diff --git a/packages/crashlytics/ios/Plugin/FirebaseCrashlyticsPlugin.swift b/packages/crashlytics/ios/Plugin/FirebaseCrashlyticsPlugin.swift
@@ -19,8 +19,12 @@ public class FirebaseCrashlyticsPlugin: CAPPlugin {
     }
 
     @objc func crash(_ call: CAPPluginCall) {
+        guard let message = call.getString("message") else {
+            call.reject(errorMessageMissing)
+            return
+        }
         call.resolve()
-        implementation?.crash()
+        implementation?.crash(message)
     }
 
     @objc func setCustomKey(_ call: CAPPluginCall) {