Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test_upload_large_file should open file in binary file mode #486

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

azrle
Copy link
Contributor

@azrle azrle commented Nov 23, 2020

Hi @leehambley @mattbrictson

Start working on #483. But I found that the local test dose not pass in my local environment (ruby version: 2.6.6 / macOS).

The test_upload_large_file failed to pass the test due to encoding issue.

...
205 tests, 3381 assertions, 0 failures, 0 errors, 0 skips
...
  test_upload_large_file                                          FAIL (22.06s)
        --- expected
        +++ actual
        @@ -1,3 +1,3 @@
        -# encoding: UTF-8
        - (snipped)
        -#    valid: false
        +# encoding: ASCII-8BIT
        +#    valid: true
        + (snipped)
...
25 tests, 35 assertions, 1 failures, 0 errors, 0 skips

After this fix:

205 tests, 3381 assertions, 0 failures, 0 errors, 0 skips
...
  test_upload_large_file                                          PASS (2.03s)
...
25 tests, 35 assertions, 0 failures, 0 errors, 0 skips

@leehambley
Copy link
Member

Excellent catch, thank you for the contribution.

@leehambley leehambley merged commit e9d2f78 into capistrano:master Nov 23, 2020
@azrle azrle deleted the fix/test_upload_large_file branch November 24, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants