migrate CI build from travis to GitHub Actions #507

colorbox · 2023-02-01T18:06:21Z

This PR migrate a CI build from Travis to GitHub Actions.

closes: #504

colorbox · 2023-02-01T18:08:00Z

CI build is fail now.
#508 will fix that.

mattbrictson

Thanks for the PR! Some of the checks are passing, but there are some issues. See comments below.

mattbrictson · 2023-02-01T20:03:05Z

.github/workflows/ci.yml

+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [2.7, 3.0, 3.1, 3.2, head]


I think these should be strings. The yaml parser is casting 3.0 to the integer 3, and this causes setup-ruby to install the latest Ruby 3.x version (3.2) instead of the desired 3.0.x.

Suggested change

ruby: [2.7, 3.0, 3.1, 3.2, head]

ruby: ["2.7", "3.0", "3.1", "3.2", "head"]

I don't know that...
Thx, I'll fix it.

mattbrictson · 2023-02-01T20:05:44Z

.github/workflows/ci.yml

+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - name: Run tests
+        run: bundle exec rake test:units lint


We need to move lint out into its own job. The version of Rubocop we are using does not work on newer versions of Ruby, so we can't have it run as part of the Ruby matrix.

Suggested change

run: bundle exec rake test:units lint

run: bundle exec rake test:units

A separate job for Rubocop could look like this:

rubocop: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - name: Set up Ruby uses: ruby/setup-ruby@v1 with: ruby-version: "2.7" bundler-cache: true - name: Run rubocop run: bundle exec rake lint

What do you think?

IMO, It is better to update Rubocop version and settings propery, but It is not appropriate on this PR.
Another PR is proper.

Separating a test and a lint is sounds good for me, 1 task 1 purpose.
So I separate test and lint on this PR, thank you example one 🙏
Updating settings or so will try by future PR by someone.

mattbrictson · 2023-02-01T20:06:17Z

README.md

@@ -4,7 +4,7 @@
 more servers.

 [![Gem Version](https://badge.fury.io/rb/sshkit.svg)](https://rubygems.org/gems/sshkit)
-[![Build Status](https://travis-ci.org/capistrano/sshkit.svg?branch=master)](https://travis-ci.org/capistrano/sshkit)
+[![Build Status](https://github.com/capistrano/sshkit/actions/workflows/test.yml/badge.svg)](https://github.com/capistrano/sshkit/actions/workflows/test.yml)


Should this be ci.yml?

Suggested change

[![Build Status](https://github.com/capistrano/sshkit/actions/workflows/test.yml/badge.svg)](https://github.com/capistrano/sshkit/actions/workflows/test.yml)

[![Build Status](https://github.com/capistrano/sshkit/actions/workflows/ci.yml/badge.svg)](https://github.com/capistrano/sshkit/actions/workflows/ci.yml)

oops I'll fix it.

mattbrictson

This looks great! One small remaining request about using the latest actions/checkout@v3 if you could take one more look. Thanks!

mattbrictson · 2023-02-02T23:37:43Z

.github/workflows/ci.yml

+      matrix:
+        ruby: ["2.7", "3.0", "3.1", "3.2", "head"]
+    steps:
+      - uses: actions/checkout@v2


I think we should stay up to date with the latest version of checkout, which is currently v3. Do you mind changing it?

Suggested change

- uses: actions/checkout@v2

- uses: actions/checkout@v3

mattbrictson · 2023-02-02T23:37:51Z

.github/workflows/ci.yml

+  rubocop:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2


Also here:

Suggested change

- uses: actions/checkout@v2

- uses: actions/checkout@v3

mattbrictson

I'm reviewing the old Travis config and I am finding some more things that were overlooked. I'd like to maintain parity with what Travis used to provide for us.

mattbrictson · 2023-02-02T23:43:15Z

.github/workflows/ci.yml

+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: ["2.7", "3.0", "3.1", "3.2", "head"]


The Travis build tested all the way back to Ruby 2.0. Backwards compatibility is a big deal for sshkit and so I wouldn't want to lose that coverage. Can you add those missing versions?

Suggested change

ruby: ["2.7", "3.0", "3.1", "3.2", "head"]

ruby: ["2.0", "2.1", "2.2", "2.3", "2.4", "2.5", "2.6", "2.7", "3.0", "3.1", "3.2", "head"]

mattbrictson · 2023-02-02T23:44:15Z

.travis.yml

-  include:
-    # Run Danger only once, on 2.5
-    - rvm: 2.5
-      script: bundle exec danger


Looks like danger got left behind as well. Can you include running this as its own job in the GitHub actions config?

okay I'll add it

mattbrictson

This is very close! One last request 🙏

mattbrictson · 2023-02-03T17:44:06Z

.github/workflows/ci.yml

+      - name: Run rubocop
+        run: bundle exec rake lint
+
+  danger:


Hmm. The danger job is failing for some reason. Looks like setting it up will be more involved. Can you remove the danger job for now? I can try adding it back in a separate PR.

removing done 👍

This PR migrate a CI build from Travis to GitHub Actions. closes: capistrano#504

mattbrictson

Great! Thank you for the contribution! ✨

mattbrictson requested changes Feb 1, 2023

View reviewed changes

colorbox force-pushed the migrate_ci_from_travis_to_github_actions branch 2 times, most recently from 47aad55 to ccd93e4 Compare February 2, 2023 17:06

mattbrictson requested changes Feb 2, 2023

View reviewed changes

colorbox force-pushed the migrate_ci_from_travis_to_github_actions branch from ccd93e4 to ded807e Compare February 3, 2023 17:34

mattbrictson requested changes Feb 3, 2023

View reviewed changes

colorbox force-pushed the migrate_ci_from_travis_to_github_actions branch 2 times, most recently from d30227a to 0ab3fa2 Compare February 3, 2023 17:46

migrate CI build from travis to GitHub Actions

2f05783

This PR migrate a CI build from Travis to GitHub Actions. closes: capistrano#504

colorbox force-pushed the migrate_ci_from_travis_to_github_actions branch from 0ab3fa2 to 2f05783 Compare February 3, 2023 17:48

mattbrictson approved these changes Feb 3, 2023

View reviewed changes

mattbrictson merged commit 09122a3 into capistrano:master Feb 3, 2023

mattbrictson added the 🏠 Housekeeping Non-user facing cleanup and maintenance label Feb 3, 2023

colorbox deleted the migrate_ci_from_travis_to_github_actions branch February 4, 2023 03:23

mattbrictson mentioned this pull request May 23, 2023

Switch from CircleCI to GitHub Actions capistrano/capistrano#2131

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migrate CI build from travis to GitHub Actions #507

migrate CI build from travis to GitHub Actions #507

colorbox commented Feb 1, 2023

colorbox commented Feb 1, 2023

mattbrictson left a comment

mattbrictson Feb 1, 2023

colorbox Feb 2, 2023

mattbrictson Feb 1, 2023 •

edited

Loading

colorbox Feb 2, 2023

mattbrictson Feb 1, 2023

colorbox Feb 2, 2023

mattbrictson left a comment

mattbrictson Feb 2, 2023

mattbrictson Feb 2, 2023

mattbrictson left a comment

mattbrictson Feb 2, 2023

mattbrictson Feb 2, 2023

colorbox Feb 3, 2023

mattbrictson left a comment

mattbrictson Feb 3, 2023

colorbox Feb 3, 2023

mattbrictson left a comment

	ruby: [2.7, 3.0, 3.1, 3.2, head]
	ruby: ["2.7", "3.0", "3.1", "3.2", "head"]

	run: bundle exec rake test:units lint
	run: bundle exec rake test:units

	[![Build Status](https://github.com/capistrano/sshkit/actions/workflows/test.yml/badge.svg)](https://github.com/capistrano/sshkit/actions/workflows/test.yml)
	[![Build Status](https://github.com/capistrano/sshkit/actions/workflows/ci.yml/badge.svg)](https://github.com/capistrano/sshkit/actions/workflows/ci.yml)

	ruby: ["2.7", "3.0", "3.1", "3.2", "head"]
	ruby: ["2.0", "2.1", "2.2", "2.3", "2.4", "2.5", "2.6", "2.7", "3.0", "3.1", "3.2", "head"]

migrate CI build from travis to GitHub Actions #507

migrate CI build from travis to GitHub Actions #507

Conversation

colorbox commented Feb 1, 2023

colorbox commented Feb 1, 2023

mattbrictson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattbrictson Feb 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattbrictson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattbrictson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattbrictson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattbrictson left a comment

Choose a reason for hiding this comment

mattbrictson Feb 1, 2023 •

edited

Loading