Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling closed? outside of synchronize block #534

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Avoid calling closed? outside of synchronize block #534

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
552648e
Avoid calling closed? outside of synchronize block
djmb Apr 1, 2024
519fc41
Update lib/sshkit/backends/connection_pool/cache.rb
djmb Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/sshkit/backends/connection_pool/cache.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ def push(conn)
def evict
# Peek at the first connection to see if it is still fresh. If so, we can
# return right away without needing to use `synchronize`.
first_expires_at, first_conn = connections.first
return if (first_expires_at.nil? || fresh?(first_expires_at)) && !closed?(first_conn)
first_expires_at, _first_conn = connections.first
return if (first_expires_at.nil? || fresh?(first_expires_at))

connections.synchronize do
fresh, stale = connections.partition do |expires_at, conn|
Expand Down