Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'symfony assets:dump' not called during deployment #15

Closed
wants to merge 1 commit into from
Closed

'symfony assets:dump' not called during deployment #15

wants to merge 1 commit into from

Conversation

kingcrunch
Copy link

Somehow the roles get lost capistrano invokes symfony:command from deploy:assets:install. Somebody with more Ruby-experience can probably debug this further, but this one at least works.

Fixes #10

@blaugueux
Copy link
Contributor

I also have this issue on a project. For me none tasks using invoke "symfony:command" works except the first one.

You can see bellow that the "symfony:command" call only run the first time.

Example:

** Invoke symfony:cache:warmup (first_time)
** Execute symfony:cache:warmup
** Invoke symfony:command (first_time)
** Execute symfony:command
executing
...
** Invoke deploy:assets:install (first_time)
** Execute deploy:assets:install
** Invoke symfony:command 
** Invoke symfony:assetic:dump (first_time)
** Execute symfony:assetic:dump
** Invoke symfony:command 
...

@blaugueux
Copy link
Contributor

I've made some other tests. My analyse seems to be right. All calls to the "symfony:command" task after the first one are not executed.

I'm looking to fix that but i'm not a ruby expert. Any help can be really useful here.

@kingcrunch BTW this PR does not solve the issue but only your case.

@kingcrunch
Copy link
Author

@blaugueux

BTW this PR does not solve the issue but only your case.

Not, that I havent said that 😉

I must admit, that I don't understand your example. "invoke X (first_time)" vs "execute X"? Especially since it doesn't invoke symfony:command even the first time, because else I would have assets installed and I wouldn't have a problem 😉

Update: Don't get me wrong. If you can fix both issues while still using symfony:command, I'd vote for that 😄

@blaugueux
Copy link
Contributor

@kingcrunch I know it's ok ;)

When you run deploy --trace you can see that if your deploy need to call the symfony:command task more than one time (symfony:asset:install and symfony:cache:warmup for example) only the first call will be executed.

In my example (my log extract), the cache warmup will be executed but neither the assets install or assetic dump.

@kingcrunch
Copy link
Author

@blaugueux Nice to know, thanks. I'll try it out.

@blaugueux
Copy link
Contributor

@kingcrunch can you try my PR #16 please, it fix the issue in my case.

@kingcrunch
Copy link
Author

#16 seems to be the better (because more) stable solution.

@kingcrunch kingcrunch closed this Apr 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems that some tasks dit not run
2 participants