Fixes overflow bug if moments are large #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGSweets
added
Bug
JGSweets
requested review from
grant-eden,
ChrisWallace2020,
ksneab7 and
taylorfturner
as code owners
JGSweets
commented
Jun 7, 2022
| @@ -318,7 +318,8 @@ def biased_skew(df_series): | |||
| if (M2 == 0): | |||
| return 0.0 | |||
|
|
|||
| skew = np.sqrt(n) * M3 / M2 ** 1.5 | |||
| with np.errstate(all='ignore'): | |||
There was a problem hiding this comment.
fix (1/2) is here
JGSweets
commented
Jun 7, 2022
| @@ -354,7 +355,8 @@ def biased_kurt(df_series): | |||
| if (M2 == 0): | |||
| return -3.0 | |||
|
|
|||
| kurt = n * M4 / M2 ** 2 - 3 | |||
ksneab7
approved these changes
Jun 7, 2022
taylorfturner
approved these changes
Jun 7, 2022
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overflow error would occur if M2 was large and powered.
This PR fixes the above error. However, a long term fix would be potentially iterating through large data to ensure smaller moments.