Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformatted dataprofiler/tests using black. #511

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Reformatted dataprofiler/tests using black. #511

merged 2 commits into from
Jul 7, 2022

Conversation

jakleh
Copy link
Contributor

@jakleh jakleh commented Jul 7, 2022

No description provided.

Copy link
Contributor

@taylorfturner taylorfturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a situation where isort is only sorting and black is dealing with formatting of the imports... just double check on that @jakleh

Comment on lines -2 to +4
from dataprofiler.tests.profilers.profiler_options.test_boolean_option import \
TestBooleanOption
from dataprofiler.tests.profilers.profiler_options.test_boolean_option import (
TestBooleanOption,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simliar comment around isort v black 🤔 @jakleh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's solve this post.

Comment on lines -4 to +6
from dataprofiler.tests.profilers.profiler_options.abstract_test_options import \
AbstractTestOptions
from dataprofiler.tests.profilers.profiler_options.abstract_test_options import (
AbstractTestOptions,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Comment on lines -2 to +4
from dataprofiler.tests.profilers.profiler_options.test_base_option import \
TestBaseOption
from dataprofiler.tests.profilers.profiler_options.test_base_option import (
TestBaseOption,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Comment on lines -2 to +4
from dataprofiler.tests.profilers.profiler_options.test_base_inspector_options import \
TestBaseInspectorOptions
from dataprofiler.tests.profilers.profiler_options.test_base_inspector_options import (
TestBaseInspectorOptions,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@taylorfturner taylorfturner merged commit 69d7173 into capitalone:main Jul 7, 2022
@jakleh jakleh deleted the black_tests branch July 11, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants