Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add property array to continuous distribution profile in GraphProfiler/ Integer Node ID identified as Integer in GraphData #579

Merged
merged 6 commits into from
Aug 5, 2022
Merged

Add property array to continuous distribution profile in GraphProfiler/ Integer Node ID identified as Integer in GraphData #579

merged 6 commits into from
Aug 5, 2022

Conversation

MisterPNP
Copy link
Contributor

Add property array to continuous distribution profile in GraphProfiler, necessary for tasks requiring replication of distribution.

@MisterPNP
add properties list to current profile for continuous distribution. N…
74147ab 
…ecessary for synthetic grapoh generation or other tasks where reproducing the distribution is necessary
@taylorfturner taylorfturner enabled auto-merge (squash) August 4, 2022 19:35
auto-merge was automatically disabled August 4, 2022 19:37

Head branch was pushed to by a user without write access

taylorfturner
taylorfturner suggested changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@taylorfturner taylorfturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple changes for more DRY code

dataprofiler/tests/profilers/test_graph_profiler.py Outdated Show resolved Hide resolved
dataprofiler/tests/profilers/test_graph_profiler.py Outdated Show resolved Hide resolved
dataprofiler/tests/profilers/test_graph_profiler.py Outdated Show resolved Hide resolved
dataprofiler/profilers/graph_profiler.py Outdated Show resolved Hide resolved
@MisterPNP MisterPNP changed the title Add property array to continuous distribution profile in GraphProfiler Add property array to continuous distribution profile in GraphProfiler/ Integer Node ID identified as Integer in GraphData Aug 5, 2022
taylorfturner
taylorfturner previously approved these changes Aug 5, 2022
View reviewed changes
@taylorfturner taylorfturner enabled auto-merge (squash) August 5, 2022 13:45
@taylorfturner taylorfturner added High Priority Dramatic improvement, inaccurate calculation(s) or bug / feature making the library unusable New Feature A feature addition not currently in the library labels Aug 5, 2022
auto-merge was automatically disabled August 5, 2022 19:17

Head branch was pushed to by a user without write access

@JGSweets JGSweets enabled auto-merge (squash) August 5, 2022 19:29
@JGSweets JGSweets merged commit 8e4089a into capitalone:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorfturner taylorfturner taylorfturner approved these changes

@JGSweets JGSweets JGSweets approved these changes

@ksneab7 ksneab7 Awaiting requested review from ksneab7

@micdavis micdavis Awaiting requested review from micdavis

@tyfarnan tyfarnan Awaiting requested review from tyfarnan

Assignees

@MisterPNP MisterPNP

Labels
High Priority Dramatic improvement, inaccurate calculation(s) or bug / feature making the library unusable New Feature A feature addition not currently in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MisterPNP @JGSweets @taylorfturner