Static Typing profilers/column profile #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonywu315
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
taylorfturner
approved these changes
Sep 22, 2022
micdavis
approved these changes
Sep 22, 2022
JGSweets
reviewed
Sep 22, 2022
| @@ -209,9 +218,9 @@ def _merge_order( | |||
| ) or order == "random": | |||
| piecewise = False | |||
|
|
|||
| return order, first_value, last_value, piecewise | |||
| return order, cast(int, first_value), cast(int, last_value), piecewise | |||
There was a problem hiding this comment.
Does this need to be casted or is optional an acceptable output arg?
There was a problem hiding this comment.
I think first_value and last_value are always not None because one of the conditionals on lines 205 to 213 will run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#608