Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added static typing to data_readers/base_data.py and data_readers/json_data.py #666

Merged
merged 12 commits into from
Oct 7, 2022
Merged

Added static typing to data_readers/base_data.py and data_readers/json_data.py #666

merged 12 commits into from
Oct 7, 2022

Conversation

Sanketh7
Copy link
Contributor

@taylorfturner
Copy link
Contributor

@Sanketh7 conflict on avro_data.py FYI

taylorfturner
taylorfturner reviewed Sep 28, 2022
View reviewed changes
Copy link
Contributor

@taylorfturner taylorfturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments around code changes and reasons for those changes

dataprofiler/data_readers/avro_data.py Outdated Show resolved Hide resolved
dataprofiler/data_readers/avro_data.py Outdated Show resolved Hide resolved
dataprofiler/data_readers/json_data.py Outdated Show resolved Hide resolved
dataprofiler/data_readers/json_data.py Outdated Show resolved Hide resolved
dataprofiler/data_readers/json_data.py Outdated Show resolved Hide resolved
@taylorfturner taylorfturner added the static_typing mypy static typing issues label Sep 28, 2022
@taylorfturner taylorfturner enabled auto-merge (squash) September 30, 2022 14:41
auto-merge was automatically disabled October 4, 2022 14:47

Head branch was pushed to by a user without write access

@micdavis micdavis enabled auto-merge (squash) October 7, 2022 14:30
@micdavis micdavis merged commit 68b52d1 into capitalone:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorfturner taylorfturner taylorfturner left review comments

@micdavis micdavis micdavis approved these changes

@JGSweets JGSweets JGSweets approved these changes

@ksneab7 ksneab7 Awaiting requested review from ksneab7

@tyfarnan tyfarnan Awaiting requested review from tyfarnan

Assignees

@Sanketh7 Sanketh7

Labels
static_typing mypy static typing issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sanketh7 @taylorfturner @JGSweets @micdavis