Add static typing to labeler utils #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonywu315
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
tonywu315
commented
Sep 29, 2022
tonywu315
commented
Sep 29, 2022
|
|
||
| if y_type.startswith("multilabel"): | ||
| average_options = ("micro", "macro", "weighted", "samples") | ||
| average_options: Tuple[str, ...] = ("micro", "macro", "weighted", "samples") |
There was a problem hiding this comment.
why the ... do we not want to enforce a len of four? so something like Tuple[str, str, str, str]?
There was a problem hiding this comment.
The next line is a tuple with length 3
There was a problem hiding this comment.
There was a problem hiding this comment.
To specify a variable-length tuple of homogeneous type, use literal ellipsis, e.g. Tuple[int, ...]. A plain [Tuple](https://docs.python.org/3/library/typing.html#typing.Tuple) is equivalent to Tuple[Any, ...], and in turn to [tuple](https://docs.python.org/3/library/stdtypes.html#tuple).
auto-merge was automatically disabled
September 29, 2022 20:20
Head branch was pushed to by a user without write access
taylorfturner
approved these changes
Sep 29, 2022
micdavis
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#609