Add static typing to labelers/data_processing.py #673
Conversation
tonywu315
requested review from
JGSweets,
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Co-authored-by: Taylor Turner <[email protected]>
|
@tonywu315 tests failing on 3.7 and 3.8 |
Head branch was pushed to by a user without write access
tonywu315
force-pushed
the
static_typing/labelers/processing
branch
from
5c9675c
to
09c6302
Compare
| @@ -74,6 +74,7 @@ def __eq__(self, other: BaseModel) -> bool: # type: ignore | |||
| """ | |||
| if ( | |||
| type(self) != type(other) | |||
| or not isinstance(other, BaseModel) | |||
There was a problem hiding this comment.
This theoretically should be covered by above, but does mypy get confused?
There was a problem hiding this comment.
yeah mypy thinks other is still an object
There was a problem hiding this comment.
type(self) != type(other) should validate that not isinstance(other, BaseDataProcessor) would return True. Just a redundant check. I'm fine with it --> better than #type: ignore and casting IMO
taylorfturner
dismissed
their stale review
dismissing my own review since I updated branch
| if type(self) != type(other) or self._parameters != other._parameters: | ||
| if ( | ||
| type(self) != type(other) | ||
| or not isinstance(other, BaseDataProcessor) |
There was a problem hiding this comment.
same, another mypy confused?
There was a problem hiding this comment.
type(self) != type(other) should validate that not isinstance(other, BaseDataProcessor) would return True. Just a redundant check
#609